Add a clippy allow exception to make CI happy/green #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bebe720, I already mentioned that there are two clippy warnings left and that a fix got merged - I just failed to realize that the fix probably won't be backported to the toolchain version 1.75 (given that the fix isn't that important as the lint only emits warnings by default and the flagged usage is probably not that common). Anyway, this makes the CI checks green again (they're currently red as an optional test fails - this test will also become required once version 1.75 hits the stable channel (unless the clippy fix would be backported before that)). Signed-off-by: Michael Weiss <[email protected]>
Merged
via the queue into
science-computing:master
with commit Nov 30, 2023
09313eb
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bebe720, I already mentioned that there are two clippy warnings left and that a fix got merged - I just failed to realize that the fix probably won't be backported to the toolchain version 1.75 (given that the fix isn't that important as the lint only emits warnings by default and the flagged usage is probably not that common). Anyway, this makes the CI checks green again (they're currently red as an optional test fails - this test will also become required once version 1.75 hits the stable channel (unless the clippy fix would be backported before that)).